Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SPHINXPROJ from new Makefile/make.bat. #4954

Merged
merged 1 commit into from May 11, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 10, 2018

Subject: Remove unused SPHINXPROJ from new Makefile/make.bat.

Feature or Bugfix

Bugfix

Purpose

The SPHINXPROJ makefile variable has become unused since #4354. Remove it.

Detail

See above.

Relates

N/A

@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #4954 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4954      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.01%     
==========================================
  Files         294      289       -5     
  Lines       38635    38313     -322     
  Branches     5953     5899      -54     
==========================================
- Hits        31766    31498     -268     
+ Misses       5547     5500      -47     
+ Partials     1322     1315       -7
Impacted Files Coverage Δ
sphinx/make_mode.py 1.12% <ø> (+0.01%) ⬆️
sphinx/builders/html.py 82.37% <0%> (-0.12%) ⬇️
sphinx/quickstart.py
sphinx/__init__.py
sphinx/search/__init__.py
sphinx/errors.py
sphinx/apidoc.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169297d...f101bb6. Read the comment docs.

@tk0miya tk0miya added this to the 1.8 milestone May 11, 2018
@tk0miya tk0miya merged commit e47cfe8 into sphinx-doc:master May 11, 2018
@tk0miya
Copy link
Member

tk0miya commented May 11, 2018

Thanks!

@anntzer anntzer deleted the nosphinxproj branch May 11, 2018 14:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants