Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4979: latex: Incorrect escaping of curly braces in index entries #4987

Merged
merged 2 commits into from
May 21, 2018

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 19, 2018

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 1.7.5 milestone May 19, 2018
@tk0miya tk0miya requested a review from jfbu May 19, 2018 05:16
@codecov
Copy link

codecov bot commented May 19, 2018

Codecov Report

Merging #4987 into 1.7 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.7    #4987      +/-   ##
==========================================
+ Coverage   81.99%   81.99%   +<.01%     
==========================================
  Files         282      287       +5     
  Lines       37675    38000     +325     
  Branches     5846     5900      +54     
==========================================
+ Hits        30890    31158     +268     
- Misses       5481     5528      +47     
- Partials     1304     1314      +10
Impacted Files Coverage Δ
tests/test_build_latex.py 95.1% <100%> (ø) ⬆️
sphinx/writers/latex.py 87.33% <100%> (+0.04%) ⬆️
sphinx/builders/html.py 82.54% <0%> (-0.12%) ⬇️
sphinx/apidoc.py 0% <0%> (ø)
sphinx/errors.py 68.42% <0%> (ø)
sphinx/search/__init__.py 95.11% <0%> (ø)
sphinx/__init__.py 57.5% <0%> (ø)
sphinx/quickstart.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679002c...0261b76. Read the comment docs.

Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya tk0miya merged commit 713aa82 into sphinx-doc:1.7 May 21, 2018
@tk0miya
Copy link
Member Author

tk0miya commented May 21, 2018

Thank you for quick reviewing :-)

@tk0miya tk0miya deleted the 4979_latex_index_escaping branch May 21, 2018 11:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants