Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karma dependency for JS tests #5295

Merged
merged 1 commit into from Aug 16, 2018

Conversation

TimKam
Copy link
Member

@TimKam TimKam commented Aug 13, 2018

As discussed here.
The version of the Karma test runner we use for JS unit tests has dependencies with low-moderate security vulnerabilities. This is not a security issue for Sphinx, because Sphinx does not include these dependencies in any release. But anyway, as Karma has now updated the corresponding dependencies, we should update our Karma version.

Relates

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #5295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5295   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         296      296           
  Lines       39346    39346           
  Branches     6058     6058           
=======================================
  Hits        32349    32349           
  Misses       5669     5669           
  Partials     1328     1328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77216c...1878a52. Read the comment docs.

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TimKam TimKam merged commit 3834c6a into sphinx-doc:master Aug 16, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants