Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sphinx.util.typing.unicode and remove all usage #5745

Closed
wants to merge 1 commit into from
Closed

Deprecate sphinx.util.typing.unicode and remove all usage #5745

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Contributor

The definition is unnecessary.

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #5745 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5745      +/-   ##
==========================================
+ Coverage   83.23%   83.24%   +<.01%     
==========================================
  Files         296      296              
  Lines       39625    39621       -4     
  Branches     5881     5880       -1     
==========================================
  Hits        32982    32982              
+ Misses       5279     5275       -4     
  Partials     1364     1364
Impacted Files Coverage Δ
sphinx/versioning.py 82.24% <ø> (ø) ⬆️
sphinx/ext/mathbase.py 48.57% <ø> (ø) ⬆️
sphinx/writers/html.py 88.67% <ø> (ø) ⬆️
sphinx/domains/changeset.py 88.88% <ø> (ø) ⬆️
sphinx/builders/latex/__init__.py 78.26% <ø> (ø) ⬆️
sphinx/config.py 82.74% <ø> (ø) ⬆️
sphinx/ext/inheritance_diagram.py 37.66% <ø> (ø) ⬆️
sphinx/locale/__init__.py 76.76% <ø> (ø) ⬆️
sphinx/util/inventory.py 92.72% <ø> (ø) ⬆️
sphinx/util/__init__.py 67.28% <ø> (ø) ⬆️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63af636...c903379. Read the comment docs.

@tk0miya
Copy link
Member

tk0miya commented Dec 10, 2018

Sorry, I'm using this now for migration to mypy-py3 mode. So please keep this as is for a while.

Note: this is added only in master branch. So deprecation is not needed because it is not released yet.

@jdufresne
Copy link
Contributor Author

Instead of using the alias, wouldn't it make more sense to change the uses of unicode to str? What is the rationale? Or is that considered "step 2" in the process?

The definition is unnecessary.
@tk0miya
Copy link
Member

tk0miya commented Dec 11, 2018

Yes, I'll replace all unicode types after migration to mypy-py3 mode. I hope this alias makes the "diff" of the migration pull request small and review-able.

@tk0miya
Copy link
Member

tk0miya commented Dec 12, 2018

Yes, I'll replace all unicode types after migration to mypy-py3 mode.

Now I'm working for mypy-py3 mode in #5760. And I'll merge it after a while (if no objection). After that, I'll replace all of unicode type with str type.

@tk0miya
Copy link
Member

tk0miya commented Dec 15, 2018

I replaced all "unicode" type by "str" in #5773.
Thanks,

@tk0miya tk0miya closed this Dec 15, 2018
@jdufresne jdufresne deleted the typing branch December 15, 2018 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants