Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecation policy by semantic versioning rules #5905

Closed
wants to merge 1 commit into from
Closed

Update deprecation policy by semantic versioning rules #5905

wants to merge 1 commit into from

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jan 7, 2019

Feature or Bugfix

  • docs

Purpose

  • We'll adopt semantic versioning since 2.0 release.
  • This updates our deprecation policy for post 2.0 release.

@tk0miya tk0miya added this to the 2.0.0 milestone Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@353c3e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5905   +/-   ##
=========================================
  Coverage          ?   83.11%           
=========================================
  Files             ?      293           
  Lines             ?    39392           
  Branches          ?     5875           
=========================================
  Hits              ?    32739           
  Misses            ?     5296           
  Partials          ?     1357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353c3e9...2fdeb4c. Read the comment docs.

@shimizukawa shimizukawa mentioned this pull request Jan 12, 2019
Merged
shimizukawa
shimizukawa reviewed Jan 12, 2019
View reviewed changes
Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed with @tk0miya on face to face, I made a alternative proposal of this PR: #5938

@tk0miya
Copy link
Member Author

tk0miya commented Jan 13, 2019

Closing. see #5938 .

@tk0miya tk0miya closed this Jan 13, 2019
@tk0miya tk0miya deleted the update_CONTRIBUTING2 branch January 13, 2019 02:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shimizukawa shimizukawa shimizukawa left review comments

@jfbu jfbu jfbu approved these changes

Assignees
No one assigned
Labels
type:docs
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tk0miya @shimizukawa @jfbu @Screech23