Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecation warnings #6224

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Show deprecation warnings #6224

merged 2 commits into from
Mar 30, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Mar 29, 2019

Feature or Bugfix

  • Bugfix

Purpose

  • viewcode_import and sphinx.application.CONFIG_FILENAME has been marked as deprecated. But no warnings are emitted for them.

@tk0miya tk0miya added this to the 2.0.1 milestone Mar 29, 2019
@tk0miya tk0miya changed the base branch from master to 2.0.1 March 29, 2019 15:46
@tk0miya tk0miya closed this Mar 29, 2019
@tk0miya tk0miya reopened this Mar 29, 2019
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #6224 into 2.0.1 will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.0.1    #6224      +/-   ##
==========================================
- Coverage   83.55%   83.54%   -0.01%     
==========================================
  Files         272      272              
  Lines       39349    39354       +5     
  Branches     5867     5868       +1     
==========================================
+ Hits        32878    32879       +1     
- Misses       5124     5126       +2     
- Partials     1347     1349       +2
Impacted Files Coverage Δ
sphinx/application.py 77.35% <100%> (+0.06%) ⬆️
sphinx/ext/viewcode.py 80.76% <100%> (+0.12%) ⬆️
tests/test_ext_inheritance_diagram.py 100% <100%> (ø) ⬆️
sphinx/util/osutil.py 70.74% <20%> (-1.48%) ⬇️
sphinx/testing/fixtures.py 85.32% <0%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765a92b...d279f58. Read the comment docs.

@tk0miya tk0miya merged commit cbefc01 into sphinx-doc:2.0.1 Mar 30, 2019
@tk0miya tk0miya deleted the deprecation branch March 30, 2019 10:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant