Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #6361: autodoc: Add autodoc_typehints to suppress typehints from signature #6397

Merged
merged 1 commit into from May 31, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 25, 2019

Feature or Bugfix

  • Feature

Purpose

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature extensions:autodoc labels May 25, 2019
@tk0miya tk0miya added this to the 2.1.0 milestone May 25, 2019
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #6397 into 2.0 will increase coverage by 0.03%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #6397      +/-   ##
==========================================
+ Coverage   83.62%   83.65%   +0.03%     
==========================================
  Files         282      281       -1     
  Lines       40393    40384       -9     
  Branches     5945     5945              
==========================================
+ Hits        33779    33784       +5     
+ Misses       5282     5271      -11     
+ Partials     1332     1329       -3
Impacted Files Coverage Δ
sphinx/ext/autodoc/__init__.py 88.9% <100%> (+0.11%) ⬆️
tests/test_autodoc.py 96.97% <100%> (+0.04%) ⬆️
tests/roots/test-ext-autodoc/target/typehints.py 57.14% <57.14%> (ø)
sphinx/__init__.py
sphinx/make_mode.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e795a0...0ea380e. Read the comment docs.

@svenevs
Copy link
Contributor

svenevs commented May 29, 2019

Hey just wanted to ping you really quick to let you know I'll be testing this tomorrow. Was out of town for holiday, will have time after work tomorrow :)

@tk0miya
Copy link
Member Author

tk0miya commented May 30, 2019

Thank you for comment. Happy holiday!

Note: I'd like to merge this in this weekend because I'll ship next minor release soon :-)

@svenevs
Copy link
Contributor

svenevs commented May 31, 2019

I'd like to merge this in this weekend because I'll ship next minor release soon :-)

Please do. As IT WORKS PERFECTLY!!! Thanks again for hearing me out and fixing it correctly (rather than my hacks...), I think this is a huge improvement ❤️

Sorry again for delayed testing.

@tk0miya
Copy link
Member Author

tk0miya commented May 31, 2019

@svenevs Thank you for checking! I'm merging this now!

1 similar comment
@tk0miya
Copy link
Member Author

tk0miya commented May 31, 2019

@svenevs Thank you for checking! I'm merging this now!

@tk0miya tk0miya deleted the 6361_autodoc_typehints branch May 31, 2019 16:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions:autodoc type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants