Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to py3 style type annotation: sphinx.environment #6552

Merged
merged 11 commits into from Jul 6, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jul 6, 2019

Feature or Bugfix

  • Refactoring

Purpose

@tk0miya tk0miya added this to the 2.2.0 milestone Jul 6, 2019
@tk0miya tk0miya force-pushed the refactor_type_annotation_env branch from 3862a72 to 2623ad1 Compare July 6, 2019 03:42
@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #6552 into 2.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #6552      +/-   ##
==========================================
+ Coverage   83.75%   83.77%   +0.01%     
==========================================
  Files         266      266              
  Lines       40740    40787      +47     
  Branches     5979     5979              
==========================================
+ Hits        34121    34168      +47     
  Misses       5297     5297              
  Partials     1322     1322
Impacted Files Coverage Δ
sphinx/environment/collectors/dependencies.py 76.66% <100%> (+3.58%) ⬆️
sphinx/util/__init__.py 70.37% <100%> (ø) ⬆️
sphinx/environment/adapters/asset.py 100% <100%> (ø) ⬆️
sphinx/environment/__init__.py 77.3% <100%> (+0.87%) ⬆️
sphinx/environment/adapters/toctree.py 86.91% <100%> (+0.13%) ⬆️
sphinx/environment/collectors/title.py 90.32% <100%> (+1.03%) ⬆️
sphinx/environment/collectors/asset.py 88.63% <100%> (+0.54%) ⬆️
sphinx/environment/collectors/metadata.py 86.48% <100%> (+1.19%) ⬆️
sphinx/environment/collectors/indexentries.py 93.33% <100%> (+1.02%) ⬆️
sphinx/environment/collectors/__init__.py 80.95% <100%> (+4.48%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847a642...2623ad1. Read the comment docs.

@tk0miya tk0miya merged commit 8b4e54f into sphinx-doc:2.0 Jul 6, 2019
@tk0miya tk0miya deleted the refactor_type_annotation_env branch July 6, 2019 04:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant