Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #267: html: Eliminate prompt characters of doctest block from c… #6727

Merged
merged 1 commit into from Oct 13, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Oct 10, 2019

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #6727 into 2.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #6727      +/-   ##
==========================================
+ Coverage   83.74%   83.74%   +<.01%     
==========================================
  Files         271      271              
  Lines       41060    41066       +6     
  Branches     6007     6008       +1     
==========================================
+ Hits        34385    34391       +6     
  Misses       5345     5345              
  Partials     1330     1330
Impacted Files Coverage Δ
sphinx/transforms/__init__.py 88.72% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6334e7...6b9e0cb. Read the comment docs.

@ankostis
Copy link

That should be a goof fix till the javascript solution allows more flexibility to enable/disable copiable content.

@tk0miya tk0miya merged commit e3d3de7 into sphinx-doc:2.0 Oct 13, 2019
@tk0miya tk0miya deleted the 267_doctest_prompt_not_copyable branch October 13, 2019 07:16
@tk0miya
Copy link
Member Author

tk0miya commented Oct 13, 2019

Merged. This will be released as 2.3.0 later.

Note: I'm afraid that JS helper (like python-doc does) effects to HTML family builders (EPUB, HTMLHelp, AppleHelp and so on.). So I'd not like to add it for now.

@become-nice
Copy link

May i ask a question ? how to config it ? I can't find any information in docs.

@tk0miya
Copy link
Member Author

tk0miya commented May 18, 2020

No configurations. This change is always applied.

@V0lantis V0lantis mentioned this pull request Apr 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants