-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant type="text/javascript" from <script> elements #6925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you rebase this into 2.0 branch? Then I'll merge this soon.
Rebased 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
In HTML5, <script> elements default to MIME type text/javascript. The HTML5 living standard and MDN recommend against including the attribute. From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-type > The HTML5 specification urges authors to omit the attribute rather > than provide a redundant MIME type. From https://html.spec.whatwg.org/#the-script-element > Authors should omit the type attribute instead of redundantly setting > it.
Restored blank line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quick fix!
Merged. |
In HTML5,
<script>
elements default to MIME type text/javascript. The HTML5 living standard and MDN recommend against including the attribute.From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-type
From https://html.spec.whatwg.org/#the-script-element