Fix #7331: autodoc: a cython-function are not recognized as a function #7355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
added
type:enhancement
tk0miya
force-pushed
the
7331_cyfunction
branch
from
1a77acd
to
a46496e
Compare
tk0miya
force-pushed
the
7331_cyfunction
branch
from
a46496e
to
6b66a8c
Compare
tk0miya
changed the title
tk0miya
added
type:bug
and removed
type:enhancement
tk0miya
force-pushed
the
7331_cyfunction
branch
from
6b66a8c
to
6320d26
Compare
tk0miya
commented
Mar 22, 2020
tk0miya
force-pushed
the
7331_cyfunction
branch
from
6320d26
to
dd70d9f
Compare
McSinyx
reviewed
Mar 31, 2020
Comment on lines
+3
to
+4
| def foo(*args, **kwargs): | ||
| """Docstring.""" |
There was a problem hiding this comment.
Coincidentally, this is the only one passed correctly for functions. All pure Python functions defined in Cython has the same signature, e.g. https://mcsinyx.github.io/palace/html/reference.html#palace.sample_size
The definition of those are here: https://github.com/McSinyx/palace/blob/master/src/palace.pyx#L175
There was a problem hiding this comment.
Thank you for the info. I found my implementation does not work well.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Mar 31, 2020
tk0miya
added a commit
that referenced
this pull request
Mar 31, 2020
Fix #7355: autodoc: a signature of cython-function is not recognized well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose