Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autosummary directive wrong processing for invalid modules. #7661

Merged
merged 2 commits into from
May 16, 2020
Merged

Fix autosummary directive wrong processing for invalid modules. #7661

merged 2 commits into from
May 16, 2020

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented May 14, 2020

Make the extension autosummary not process invalid modules that raises an ImportError.

Feature or Bugfix

  • Bugfix

@mondeja mondeja marked this pull request as draft May 14, 2020 17:05
@mondeja mondeja marked this pull request as ready for review May 14, 2020 17:24
@tk0miya
Copy link
Member

tk0miya commented May 16, 2020

Looks good. But this is not related to #7552. The autosummary directive inside code-block should not work even if target modules are valid.

@tk0miya tk0miya added this to the 3.1.0 milestone May 16, 2020
@tk0miya tk0miya merged commit b8ecec8 into sphinx-doc:3.x May 16, 2020
@mondeja
Copy link
Contributor Author

mondeja commented May 16, 2020

I've removed the relation.

tk0miya added a commit that referenced this pull request May 16, 2020
@tk0miya
Copy link
Member

tk0miya commented May 16, 2020

Thanks,
Now I merged this!

Chilipp added a commit to Chilipp/sphinx that referenced this pull request Jul 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants