Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate original extension errors #7870

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

dstansby
Copy link
Contributor

Subject: Previously the exc error did not get propagated through to the constructor of ExtensionError. This fixes that so that the text of the original error gets printed.

Feature or Bugfix

  • Bugfix

Purpose

Detail

Relates

sphinx/events.py Outdated Show resolved Hide resolved
@tk0miya tk0miya added the type:proposal a feature suggestion label Jun 27, 2020
@tk0miya tk0miya added this to the 3.2.0 milestone Jun 27, 2020
@tk0miya tk0miya merged commit 1d6b311 into sphinx-doc:3.x Jul 12, 2020
@tk0miya
Copy link
Member

tk0miya commented Jul 12, 2020

Merged. Thanks!

@dstansby dstansby deleted the error-info branch July 12, 2020 10:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:proposal a feature suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension throwing an exception provides no helpful debug info
2 participants