Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6640: i18n: Failed to override system message translation #8120

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Aug 14, 2020

Feature or Bugfix

  • Bugfix

Purpose

  • refs: locale/<language>/LC_MESSAGES/sphinx.po translation ignored #6640
  • Our document describes that users can override system messages via
    their own message catalog named sphinx.mo under the locale_dirs.
    But it has not been used since its beginning of i18n mechanism because
    the priority of users' message catalog is lower than system's.
  • This makes the priority of users' message catalog higher than system's.

Remaining tasks

  • testcase

Our document describes that users can override system messages via
their own message catalog named `sphinx.mo` under the locale_dirs.
But it has not been used since its beginning of i18n mechanism because
the priority of users' message catalog is lower than system's.

This makes the priority of users' message catalog higher than system's.
@tk0miya tk0miya force-pushed the 6640_allow_to_override_system_message branch from 9fc5b9c to 37235c7 Compare October 4, 2020 04:31
@tk0miya tk0miya marked this pull request as ready for review October 4, 2020 04:31
@tk0miya tk0miya merged commit d8cb7aa into sphinx-doc:3.x Oct 4, 2020
@tk0miya tk0miya deleted the 6640_allow_to_override_system_message branch October 4, 2020 04:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant