Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Unwrap user-defined functions or methods to get correct signature #8234

Closed
wants to merge 3 commits into from
Closed

FIX Unwrap user-defined functions or methods to get correct signature #8234

wants to merge 3 commits into from

Conversation

alfaro96
Copy link

Subject: This PR fixes the signature of user-defined functions or methods that are wrapped by a decorator.

Feature or Bugfix

  • Bugfix

Purpose

  • Unwrap the user-defined functions or methods to obtain the correct signature instead of the decorator signature.

Relates

@tk0miya
Copy link
Member

tk0miya commented Jan 23, 2021

Since 3.4.0, we determined to unwrap all of functions and methods on getting signature (refs: #8362). So this change is no longer needed. Thank you for your proposal.

@tk0miya tk0miya closed this Jan 23, 2021
@alfaro96 alfaro96 deleted the unwrap_function_method branch January 23, 2021 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants