Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8268: make linkcheck report HTTP errors #8269

Merged
merged 1 commit into from Oct 3, 2020
Merged

Fix #8268: make linkcheck report HTTP errors #8269

merged 1 commit into from Oct 3, 2020

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Oct 3, 2020 •
edited

Feature or Bugfix

  • Bugfix

Purpose

tk0miya
tk0miya requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

tests/roots/test-linkcheck-localserver/conf.py Outdated Show resolved Hide resolved
tests/roots/test-linkcheck-localserver/conf.py Outdated Show resolved Hide resolved
@francoisfreitag
Copy link
Contributor Author

Thanks for the review. I copied the test project from linkcheck and did not update these references. The test case is now using the default values for master_doc and source_suffix.

@tk0miya
Copy link
Member

tk0miya commented Oct 3, 2020

Thank you for quick update. I'll merge this after all CI passed.

@tk0miya tk0miya merged commit 1eaa068 into sphinx-doc:3.x Oct 3, 2020
@tk0miya
Copy link
Member

tk0miya commented Oct 3, 2020

Merged. Thank you for your contribution!

@tk0miya tk0miya added this to the 3.3.0 milestone Oct 3, 2020
@francoisfreitag francoisfreitag deleted the raise-anchor branch October 3, 2020 19:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya tk0miya approved these changes

Assignees
No one assigned
Labels
builder type:bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Linkcheck should report HTTP errors instead of Anchor not found
2 participants
@francoisfreitag @tk0miya