-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autodoc: Add :no-value: option to autoattribute and autodata to suppress the default value of the variable #8424
Conversation
Looks good to me. Thanks for this @tk0miya! |
30d116e
to
80f6fb3
Compare
When the :annotation: option is not used, the :novalue: option may be used to remove the value. This is useful when you want to display the type hint but not the value, and you don't want to specify the annotation manually.
According to the existing options of autodoc directives, `:novalue:` option is now renamed to `:no-value:` option.
80f6fb3
to
a4ccca7
Compare
@ktbarrett Thank you for comment. Now I'm waiting for comment from garmin-mjames for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, thanks for picking this up, I haven't had time recently.
When I look at the Travis build I don't see the new tests.
Now we've migrated to GitHub Actions. Travis CI is no longer used. |
Merged. Thank you for your all! |
Feature or Bugfix
Purpose
:no-value:
option toautoattribute
andautodata
directive to suppress the default value of the variable