Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8522: sphinx could lead to __bool__ method call, what can lead to side effect or direct failure in case it generate an error bug #8523

Merged
merged 5 commits into from
Dec 12, 2020

Conversation

ArtyomKaltovich
Copy link
Contributor

@ArtyomKaltovich ArtyomKaltovich commented Dec 7, 2020

Subject: fix #8522.

Feature or Bugfix

  • Bugfix

Purpose

Prevent user code execution, see examples in #8522.

@ArtyomKaltovich ArtyomKaltovich changed the title fix 8522: sphinx could lead to __bool__ method call, what can lead to side effect or direct failure in case it generate an error bug fix #8522: sphinx could lead to __bool__ method call, what can lead to side effect or direct failure in case it generate an error bug Dec 7, 2020
CHANGES Outdated Show resolved Hide resolved
CHANGES Outdated Show resolved Hide resolved
@ArtyomKaltovich
Copy link
Contributor Author

Hello @tk0miya.

I've fixed changes and resolve conflicts, it is ok now?

Regards,
Artyom.

@tk0miya
Copy link
Member

tk0miya commented Dec 12, 2020

LGTM. Merging now.
Thank you for your contribution!

@tk0miya tk0miya merged commit 9d96c07 into sphinx-doc:3.x Dec 12, 2020
tk0miya added a commit that referenced this pull request Dec 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants