Fix #8534: autoattribute failed to document a commented attribute in alias class #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Dec 15, 2020
| self._datadescriptor = True | ||
| else: | ||
| # if it's not a data descriptor | ||
| self._datadescriptor = False | ||
| except ImportError as exc: | ||
| if self.isinstanceattribute(): |
There was a problem hiding this comment.
I'll refactor this implementation at the next step.
…ribute in alias class So far, autoattribute uses "given class name" to fetch comments of uninitialized instance attributes. But pycode expects to use "real" class name on searching attribute comments. This adds UninitializedInstanceAttributeMixin to handle it simply.
tk0miya
force-pushed
the
8534_autoattribute_alias
branch
from
5917c6f
to
caa1d1f
Compare
tk0miya
commented
Dec 15, 2020
| @@ -29,3 +29,6 @@ def __init__(self): | |||
|
|
|||
| class Derived(Class): | |||
| attr7: int | |||
|
|
|||
|
|
|||
| Alias = Class | |||
There was a problem hiding this comment.
It would not work when this is an alias of Derived.
There was a problem hiding this comment.
I need to work more to support it. So I'll do it on another PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose