Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchtools: Don't use slideDown to show search results. #8868

Merged
merged 1 commit into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. searchtools: Don't use slideDown to show search results.

    Fixes a performance issue with massive lists like sphinx-doc#8562.
    
    jQuery.slideDown is pretty bad perf-wise since it thrashes layout
    multiple times.
    
    The 5ms animation is unnoticeable (it last less than an animation
    frame!) and just burns CPU cycles unnecessarily in all browsers.
    
    On Firefox this is specially bad because it hits a performance cliff
    with list items / CSS counters
    (https://bugzilla.mozilla.org/show_bug.cgi?id=1683910#c26 for all the
    gory details) where it causes tons of counter recalc.
    
    An alternative fix for the Firefox cliff would be to set overflow:
    hidden on the list item, but I think removing the animation is probably
    more sensible, given that as I said it's just burning CPU.
    
    Fixes sphinx-doc#8562
    emilio committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b6aaf07 View commit details
    Browse the repository at this point in the history