Fix #8915: html theme: The translation of sphinx_rtd_theme does not work #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
8915_i18n_for_sphinx_rtd_theme
branch
from
7c0d2e2
to
7c3b422
Compare
…does not work Since sphinx_rtd_theme-0.5.0, it supports translations. But Sphinx core disallows to enable it because theming framework gives special treatment for the theme for a long time. This goes to load it via setuptools at first to enable the translations. Note: The special treatment for sphinx_rtd_theme (< 0.2.5) is not removed yet. But it will be removed in the future release.
tk0miya
force-pushed
the
8915_i18n_for_sphinx_rtd_theme
branch
from
7c3b422
to
ad3edd9
Compare
tk0miya
commented
Feb 23, 2021
| @@ -30,6 +30,7 @@ Incompatible changes | |||
| * html theme: Move a script tag for documentation_options.js in | |||
| basic/layout.html to ``script_files`` variable | |||
| * html theme: Move CSS tags in basic/layout.html to ``css_files`` variable | |||
| * #8915: html theme: Emit a warning for sphinx_rtd_theme-0.2.4 or older | |||
There was a problem hiding this comment.
Note: An entry_point for setuptools was added to sphinx_rtd_theme at 0.2.5 (see readthedocs/sphinx_rtd_theme#425).
But Ubuntu-18.04 bundles v0.2.4
https://packages.ubuntu.com/bionic/python3-sphinx-rtd-theme
There was a problem hiding this comment.
I noticed v0.2.5 was not released. The next version of v0.2.4 is v0.3.0.
https://pypi.org/project/sphinx-rtd-theme/#history
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
disallows to enable it because theming framework gives special treatment
for the theme for a long time.
removed yet. But it will be removed in the next major release.