Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy violations (Third-party Library Stubs) (with mypy-0.900) #9325

Merged

Conversation

jrfk
Copy link
Contributor

@jrfk jrfk commented Jun 13, 2021

Subject: Fix mypy violations (Third-party Library Stubs) (with mypy-0.900)

Feature or Bugfix

  • Refactoring

Purpose

Fix mypy violations (Third-party Library Stubs) (with mypy-0.900)

Detail

Add to setup.py

  • types-typed-ast
  • types-pkg_resources
  • types-requests

Because, mypy 0.900 has made a Breaking Change.

Third-party Library Stubs in Stub Packages (Breaking Change)

github actions error
Excerpt.

sphinx/pycode/ast.py:19:1: error: Library stubs not installed for "typed_ast" (or incompatible with Python 3.6)
sphinx/theming.py:19:1: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.6)
sphinx/registry.py:24:1: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.6)
sphinx/util/requests.py:17:1: error: Library stubs not installed for "requests" (or incompatible with Python 3.6)
54
sphinx/util/requests.py:24:1: error: Library stubs not installed for "requests.packages.urllib3.exceptions" (or incompatible with Python 3.6)
sphinx/builders/linkcheck.py:28:1: error: Library stubs not installed for "requests" (or incompatible with Python 3.6)
sphinx/builders/linkcheck.py:29:1: error: Library stubs not installed for "requests.exceptions" (or incompatible with Python 3.6)

Relates

  • None

@tk0miya
Copy link
Member

tk0miya commented Jun 13, 2021

Thank you for your contribution :-)

There're some "ignore comment" warnings. But getting better than now. So +1 for merging.

sphinx/util/logging.py:576: error: unused "type: ignore" comment
sphinx/util/logging.py:582: error: unused "type: ignore" comment
sphinx/util/logging.py:590: error: unused "type: ignore" comment
sphinx/util/typing.py:226: error: unused "type: ignore" comment
sphinx/util/typing.py:227: error: unused "type: ignore" comment
sphinx/util/typing.py:228: error: unused "type: ignore" comment
sphinx/util/typing.py:229: error: unused "type: ignore" comment
sphinx/util/typing.py:231: error: unused "type: ignore" comment
sphinx/util/typing.py:232: error: unused "type: ignore" comment

@tk0miya tk0miya merged commit 8a59390 into sphinx-doc:4.0.x Jun 13, 2021
@tk0miya tk0miya added this to the 4.0.3 milestone Jun 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants