Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy violations (delete type: ignore ) (with mypy-0.900) #9327

Merged

Conversation

jrfk
Copy link
Contributor

@jrfk jrfk commented Jun 13, 2021

Subject: Fix mypy violations (delete type: ignore ) (with mypy-0.900)

Feature or Bugfix

  • Refactoring

Purpose

Fix mypy violations (delete type: ignore ) (with mypy-0.900)

Detail

Remove "type: ignore" from the following files

  • sphinx/util/logging.py
  • sphinx/util/typing.py

github actions error
Excerpt.

sphinx/util/logging.py:576: error: unused "type: ignore" comment
sphinx/util/logging.py:582: error: unused "type: ignore" comment
sphinx/util/logging.py:590: error: unused "type: ignore" comment
sphinx/util/typing.py:226: error: unused "type: ignore" comment
sphinx/util/typing.py:227: error: unused "type: ignore" comment
sphinx/util/typing.py:228: error: unused "type: ignore" comment
sphinx/util/typing.py:229: error: unused "type: ignore" comment
sphinx/util/typing.py:231: error: unused "type: ignore" comment
sphinx/util/typing.py:232: error: unused "type: ignore" comment

Relates

  • None

@tk0miya tk0miya added this to the 4.0.3 milestone Jun 13, 2021
@tk0miya tk0miya merged commit b7c05a2 into sphinx-doc:4.0.x Jun 13, 2021
@tk0miya
Copy link
Member

tk0miya commented Jun 13, 2021

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants