Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PEP 585 generics #9464

Merged
merged 2 commits into from Jul 19, 2021
Merged

Add support for PEP 585 generics #9464

merged 2 commits into from Jul 19, 2021

Conversation

Gobot1234
Copy link
Contributor

Subject: Add support for PEP 585's builtin generics.

Feature or Bugfix

  • Bugfix

Relates

tk0miya
tk0miya requested changes Jul 18, 2021
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a testcase for this into tests/test_util_typing.py, please?

sphinx/util/typing.py Outdated Show resolved Hide resolved
@tk0miya tk0miya added this to the 4.2.0 milestone Jul 18, 2021
@tk0miya tk0miya merged commit f9941b9 into sphinx-doc:4.x Jul 19, 2021
@tk0miya
Copy link
Member

tk0miya commented Jul 19, 2021

Merged. Thank you for your contribution!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya tk0miya requested changes

Assignees
No one assigned
Labels
extensions:autodoc type:bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

PEP 585 type hints not rendered correctly
2 participants
@Gobot1234 @tk0miya