Add start_line and end_line information in linkcode
#9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u1735067
force-pushed
the
linkcode_lines
branch
2 times, most recently
from
a3542e1
to
275d232
Compare
u1735067
force-pushed
the
linkcode_lines
branch
from
275d232
to
7858421
Compare
AA-Turner
reviewed
Oct 5, 2022
AA-Turner
reviewed
Oct 5, 2022
AA-Turner
reviewed
Oct 5, 2022
AA-Turner
reviewed
Oct 5, 2022
jayaddison
reviewed
Feb 23, 2024
| return "https://somesite/sourcerepo/%s.py" % filename | ||
| line_anchor = "" | ||
| if info['start_line'] >= 0: | ||
| line_anchor = "#L%s" % info['start_line'] |
There was a problem hiding this comment.
Any plans to add the end_line to the line anchor? It seems that the format #L10-L23 is supported by a few web-based code viewers (checked: GitHub, GitLab, Gitea, Debsources).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Add
start_lineandend_lineinformation inlinkcodeFeature or Bugfix
Purpose
linkcodeextension to add a line anchor in the generated linkDetail
infokeys forlinkcode_resolve:start_lineandend_line(Noneby default)viewcode-find-sourceevent first to find the lines informations (to be used withsphinx-autoapifor example)linkcode_line_try_importsetting) use the same import method as insphinx.ext.viewcode(
sphinx.pycode.ModuleAnalyzer) to find the line informations (same warning)Relates