Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkcheck_auth link to Requests authentication #9769

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Oct 25, 2021

The link was directing to
https://www.sphinx-doc.org/en/master/usage/requests-auth>. Prefer using
the intersphinx module to generate the link, it’s more robust than
directly linking to the page.

Feature or Bugfix

  • Bugfix

The link was directing to
https://www.sphinx-doc.org/en/master/usage/requests-auth>. Prefer using
the intersphinx module to generate the link, it’s more robust than
directly linking to the page.
@francoisfreitag francoisfreitag changed the title Fix doc linkcheck_auth link to requests authentication Fix linkcheck_auth link to Requests authentication Oct 25, 2021
@tk0miya tk0miya added this to the 4.3.0 milestone Oct 26, 2021
@tk0miya tk0miya merged commit d8b92bb into sphinx-doc:4.x Oct 26, 2021
@tk0miya
Copy link
Member

tk0miya commented Oct 26, 2021

LGTM

@francoisfreitag francoisfreitag deleted the fix-linkcheck-auth-link branch October 26, 2021 17:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants