Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brief section on documenting other languages to tutorial #9850

Merged

Conversation

astrojuanlu
Copy link
Contributor

Short follow-up to #9534 (comment), where it was discussed that it would be good to expand on the Sphinx capabilities of documenting other languages.

It sort of deviates from the main tutorial in that it doesn't add any C++ code to the supposed documentation of Lumache, but I hope it serves at least for clarifying that Sphinx is capable of much more than just documenting Python objects.

cc @tk0miya @jakobandersen

Copy link
Contributor

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
astrojuanlu and others added 2 commits November 15, 2021 14:29
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@tk0miya tk0miya added type:docs type:proposal a feature suggestion labels Nov 16, 2021
@tk0miya tk0miya added this to the 4.4.0 milestone Nov 16, 2021
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jakobandersen jakobandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a few minor changes.

doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
doc/tutorial/describing-code.rst Outdated Show resolved Hide resolved
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@astrojuanlu
Copy link
Contributor Author

Thanks both! Applied all the suggestions

@tk0miya tk0miya merged commit a63fb55 into sphinx-doc:4.x Nov 21, 2021
@tk0miya
Copy link
Member

tk0miya commented Nov 21, 2021

Merging. Good work!

@astrojuanlu astrojuanlu deleted the new-tutorial-describing-code-other branch November 21, 2021 17:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:docs type:proposal a feature suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants