Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Install jupyterlite-pyodide-kernel in CI #1107

Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Mar 17, 2023

Fix #1103.

Also used this PR to tweak the doc, it makes more sense to mention jupyterlite-sphinx version.

@@ -60,7 +60,7 @@ stages:
pip install --user --upgrade --progress-bar off "ipython!=8.7.0" numpy seaborn statsmodels matplotlib sphinx pillow pytest pytest-cov joblib "plotly>=4.0"
pip install --user --upgrade --progress-bar off --pre pydata-sphinx-theme
echo "Qt, plotly, VTK"
pip install --user --upgrade --progress-bar off pyvista "pyqt5!=5.15.8" plotly vtk jupyterlite-sphinx
pip install --user --upgrade --progress-bar off pyvista "pyqt5!=5.15.8" plotly vtk jupyterlite-sphinx jupyterlite-pyodide-kernel
Copy link

@jtpio jtpio Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a pin on jupyterlite-sphinx and jupyterlite-pyodide-kernel for now.

For example: "jupyterlite-sphinx >=0.8.0,<0.9.0" and jupyterlite-pyodide-kernel < 0.1.0. Not expecting major changes in this packages in the short term but just to be sure.

We are working on getting JupyterLite 0.1.0 out very soon and things. I can open a new issue / PR on this repo to do the update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. We don't pin anything else in the sphinx-gallery CI so we like to live dangerously it seems but we can make an exception for jupyterlite-sphinx 😉.

We are working on getting JupyterLite 0.1.0 out very soon and things. I can open a new issue / PR on this repo to do the update.

Sounds great, don't hesitate to ping me on JupyterLite-related things, otherwise I may well miss it completely!

@lesteve
Copy link
Member Author

lesteve commented Mar 18, 2023

Merging, thanks @jtpio for the feed-back!

@lesteve lesteve changed the title CI Install jupyterlite-pyodide-kernel for sphinx-jupyterlite>=0.8 CI Install jupyterlite-pyodide-kernel in CI Mar 18, 2023
@lesteve lesteve merged commit 5a0a6a5 into sphinx-gallery:master Mar 18, 2023
@lesteve lesteve deleted the install-jupyterlite-pyodide-kernel-in-ci branch March 18, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to jupyterlite-sphinx 0.8.0
3 participants