Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path class #35

Closed
wants to merge 24 commits into from
Closed

Path class #35

wants to merge 24 commits into from

Conversation

Titan-C
Copy link
Member

@Titan-C Titan-C commented Jun 7, 2015

This is more of a nice feature to have(mostly inspired by the work done in plot2rst). But that I could test and allowed me to discover the bug fixed in #34 . It extends the string class for paths, given some ease of use when working with paths.

@lesteve
Copy link
Member

lesteve commented Jul 31, 2015

@Titan-C, is that still something we want?

@GaelVaroquaux
Copy link
Contributor

GaelVaroquaux commented Jul 31, 2015 via email

@lesteve
Copy link
Member

lesteve commented Jul 31, 2015

Not entirely sure, but it looks like adding a Path class for more convenient path manipulations ...

@Titan-C
Copy link
Member Author

Titan-C commented Jul 31, 2015

What is it actually? I didn't get it from the description of the PR.

Can't really explain it better.

  • It's an internal feature, not for the user. It was inspired by the fact that the gallery has to deal with multiple paths(examples_source_dir, Gallely_dir, modules_dir, file_path, image_paths, ...)
  • The idea is to store this paths not only as strings, but in an object that is aware they are paths and provide inherent features of this. Like, joining paths, creating dir, listing dirs, checking it the path exists or is a directory.

It remains a nice feature to have which I was very eager to use, back when #36 was only aimed at refactoring the code. Now it needs an update from master.

@GaelVaroquaux
Copy link
Contributor

GaelVaroquaux commented Jul 31, 2015 via email

@Titan-C
Copy link
Member Author

Titan-C commented Oct 4, 2015

No more need for this anymore.

@Titan-C Titan-C closed this Oct 4, 2015
@Titan-C Titan-C deleted the path_class branch October 4, 2015 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants