feat(popup-lyrics): add global delay option #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxri
requested changes
Aug 23, 2022
|
Hi! Thanks for your contribution. |
Here is a screenshot where you can see the new option: |
rxri
approved these changes
Aug 23, 2022
kyrie25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is my first PR, which adds an option to the Popup Lyrics settings menu to set a global delay.
I implemented this because when I'm listening to music with my Airpods on my iPhone, while working on my computer, there always is a delay between the lyrics and the song, and I have to press pause/resume every time to fix it. With this new option, it is now possible to avoid this problem.
By default, delay is set to 0. I made the choice to use an
input type="number"because a slider / a select / two minus and plus buttons, were not convenient to select a precise value.