Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popup-lyrics): add global delay option #1882

Merged
merged 2 commits into from
Aug 23, 2022
Merged

feat(popup-lyrics): add global delay option #1882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e19a9fa
feat(popup-lyrics): add a global delay option
Aug 23, 2022
ebd9f75
style: run prettier
Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions Extensions/popupLyrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ function PopupLyrics() {
blurSize: Number(LocalStorage.get("popup-lyrics:blur-size")),
fontFamily: LocalStorage.get("popup-lyrics:font-family") || "spotify-circular",
ratio: LocalStorage.get("popup-lyrics:ratio") || "11",
delay: Number(LocalStorage.get("popup-lyrics:delay")),
services: {
netease: {
on: boolLocalStorage("popup-lyrics:services:netease:on"),
Expand Down Expand Up @@ -704,7 +705,7 @@ function PopupLyrics() {
}

const audio = {
currentTime: Player.getProgress() / 1000,
currentTime: (Player.getProgress() - Number(options.delay)) / 1000,
duration: Player.getDuration() / 1000,
};

Expand Down Expand Up @@ -807,7 +808,12 @@ button.switch.small {
padding: 0 5px;
height: 32px;
border: 0;
}`;
}
#popup-lyrics-delay-input {
background-color: rgba(var(--spice-rgb-shadow), .7);
color: var(--spice-text);
}
`;
const optionHeader = document.createElement("h2");
optionHeader.innerText = "Options";
const smooth = createSlider("Smooth scrolling", userConfigs.smooth, (state) => {
Expand Down Expand Up @@ -872,6 +878,10 @@ button.switch.small {
LocalStorage.set("popup-lyrics:blur-size", state);
}
);
const delay = createOptionsInput("Delay", String(userConfigs.delay), (state) => {
userConfigs.delay = Number(state);
LocalStorage.set("popup-lyrics:delay", state);
});

const serviceHeader = document.createElement("h2");
serviceHeader.innerText = "Services";
Expand Down Expand Up @@ -939,7 +949,7 @@ button.switch.small {
});
stackServiceElements();

configContainer.append(style, optionHeader, smooth, center, cover, blurSize, fontSize, ratio, serviceHeader, serviceContainer);
configContainer.append(style, optionHeader, smooth, center, cover, blurSize, fontSize, ratio, delay, serviceHeader, serviceContainer);
}
Spicetify.PopupModal.display({
title: "Popup Lyrics",
Expand Down Expand Up @@ -996,6 +1006,27 @@ button.switch.small {

return container;
}
function createOptionsInput(name, defaultValue, callback) {
const container = document.createElement("div");
container.innerHTML = `
<div class="setting-row">
<label class="col description">${name}</label>
<div class="col action">
<input
id="popup-lyrics-delay-input"
type="number"
/>
</div>
</div>`;

const input = container.querySelector("#popup-lyrics-delay-input");
input.value = defaultValue;
input.onchange = (e) => {
callback(e.target.value);
};

return container;
}

function createServiceOption(id, defaultVal, switchCallback, posCallback, tokenCallback) {
const name = id.replace(/^./, (c) => c.toUpperCase());
Expand Down