Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lyrics-plus/netease): check correctly for songs #3018

Merged
merged 6 commits into from
Jun 16, 2024

Conversation

dompling
Copy link
Contributor

lyrics time matching logic(For example:给我一首歌的时间)lyrics content mismatch

…example:给我一首歌的时间)lyrics content mismatch
Copy link

graphite-app bot commented May 10, 2024

Graphite Automations

"Add `custom app` label on custom app(s) related changes" took an action on this PR • (05/10/24)

1 label was added to this PR based on ririxi's automation.

dompling added 2 commits May 10, 2024 15:39
1.汉化
2.增加第三方翻译,需在有歌词的情况下
1.汉化
2.增加第三方翻译,需在有歌词的情况下
Copy link
Member

@rxri rxri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change your code to align with biome errors. Also run biome formatter on it too.

@rxri rxri changed the title fix(lyrics): apps lyrics-plus Netease fix(lyrics-plus/netease): check correctly for songs May 11, 2024
@rxri
Copy link
Member

rxri commented May 23, 2024

Any update on this? I'm still waiting for implementing the changes

@rxri rxri merged commit 22cf2b0 into spicetify:main Jun 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants