Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add prerelease tag #20

Merged
merged 3 commits into from
Feb 5, 2023
Merged

feat(cli): add prerelease tag #20

merged 3 commits into from
Feb 5, 2023

Conversation

bayou-brogrammer
Copy link
Contributor

@bayou-brogrammer bayou-brogrammer commented Feb 4, 2023 •
edited
Loading

Addresses #19

image

@bayou-brogrammer bayou-brogrammer changed the title add prerelease tag to cli feat: add prerelease tag to cli Feb 4, 2023
@bayou-brogrammer bayou-brogrammer marked this pull request as ready for review February 4, 2023 17:39
orhun
orhun reviewed Feb 4, 2023
View reviewed changes
cli/src/app.rs Outdated Show resolved Hide resolved
@orhun
Copy link
Member

orhun commented Feb 4, 2023

CI is failing. Can you run cargo clippy and apply the suggestions?

@bayou-brogrammer
Copy link
Contributor Author

@orhun

magenta
image

red:
image

yellow:
image

purple:
image

cyan
image

@zicklag
Copy link
Collaborator

zicklag commented Feb 4, 2023 •
edited
Loading

Yellow seems the most natural to me, and matches GitHub:

image

My only hesitation is that the title is also yellow, but I think yellow's probably still the best color.

Edit: Maybe it should also be pre-release instead of prerelease.

@bayou-brogrammer
Copy link
Contributor Author

Is the name of the Release color able to change too? Seems off to have the same color per line

@orhun
Copy link
Member

orhun commented Feb 4, 2023

Yeah, feel free to play with the release color too. I agree with @zicklag, it would fit better if we have yellow for the prereleases.

Edit: Maybe it should also be pre-release instead of prerelease.

Indeed 👍🏼

@bayou-brogrammer
Copy link
Contributor Author

@orhun Went with the green layout for release name :)

orhun
orhun approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun changed the title feat: add prerelease tag to cli feat(cli): add prerelease tag Feb 5, 2023
@orhun orhun merged commit 7705a1a into spicylobstergames:main Feb 5, 2023
@bayou-brogrammer bayou-brogrammer deleted the cli-prerelease branch February 5, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bayou-brogrammer @orhun @zicklag