settings::vardir does not exist on agents

[KlavsKlavsen]

The module currently uses $settings::vardir/selinux as the place to put modules.
The problem is, that I use /var/lib/puppetmaster as vardir for my master - so I have the master and agent (on same machine) seperated - but that means that you cannot assume that the servers vardir exists on the agents.

I'd set it to /var/tmp/selinux - and ensure ownership on that instead. That folder should always exist and is not emptied at boot.

[pecastro]

+1 Bumped into the same thing just now.
You can override it with selinux::params::modules_dir but then it becomes your problem and a not very portable one. :(

[wadells]

Just hit this while running a puppet master under my user for development purposes. While running this way vardir = ~/.puppet/var/ on my workstation, which doesn't exist at all on the agent machines (because my user is not present on those).

[wadells]

Suggestion: instead of $::settings::vardir lets use the $::puppet_vardir fact:

$ facter --puppet | grep var
concat_basedir => /var/lib/puppet/concat
puppet_vardir => /var/lib/puppet

https://github.com/puppetlabs/puppetlabs-stdlib/blob/0191a3fb772d3caff59ad684e02e702ae8542b1e/lib/facter/puppet_vardir.rb

[t4nec0]

+1, followed Javins comment

[necrolyte2]

+1, also changed ${::settings::vardir} to ${::puppet_vardir} and it fixed issue for me

[mike-es]

This is a blocker for me right now. +1 for Javins change/pull request