Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Update PSAT requirements documentation #385

Closed
wants to merge 3 commits into from
Closed

Update PSAT requirements documentation #385

wants to merge 3 commits into from

Conversation

cccsss01
Copy link

No description provided.

kfox1111
kfox1111 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for the fix. :)

LGTM

@cccsss01 cccsss01 closed this Jul 13, 2023
@cccsss01 cccsss01 reopened this Jul 13, 2023
@cccsss01
Copy link
Author

Well, not sure if it's really needed since it requires 1.22 anyways.

@marcofranssen marcofranssen enabled auto-merge (squash) July 15, 2023 21:30
@marcofranssen marcofranssen changed the title Update README.md Update PSAT requirements documentation Jul 15, 2023
@faisal-memon
Copy link
Contributor

Well, not sure if it's really needed since it requires 1.22 anyways.

@cccsss01 I think you are right. We should probably just remove that whole section to avoid confusion.

@marcofranssen
Copy link
Contributor

Change has to be made in https://github.com/spiffe/helm-charts/blob/main/charts/spire/README.md.gotmpl

so when we run helm-docs.sh the README.md is updated.

That is the reason for failing build.

@cccsss01 @marcofranssen
Update README.md
f6d98c5 
Signed-off-by: cccsss01 <56396984+cccsss01@users.noreply.github.com>
auto-merge was automatically disabled July 20, 2023 03:07

Head branch was pushed to by a user without write access

@cccsss01 @faisal-memon
Update charts/spire/README.md
65c1a70 
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: cccsss01 <56396984+cccsss01@users.noreply.github.com>
@faisal-memon faisal-memon added this to the 0.11.1 milestone Jul 20, 2023
@marcofranssen marcofranssen enabled auto-merge (squash) July 20, 2023 21:33
@faisal-memon
Copy link
Contributor

@cccsss01 What do you want to do here?

@faisal-memon faisal-memon modified the milestones: 0.11.1, 0.12.0 Aug 8, 2023
@marcofranssen marcofranssen mentioned this pull request Aug 9, 2023
Merged
@marcofranssen
Copy link
Contributor

We have created a new PR #437 which will move this information to a more clear location for those few usecases where people can't get PSAT to work.

This way we don't confuse the majority of users with instructions that are only required on very old k8s deployments.

@faisal-memon
Copy link
Contributor

Will be covered as part of #437 . Thanks @cccsss01 for bring this to our attention.

auto-merge was automatically disabled August 14, 2023 21:23

Pull request was closed

kfox1111 added a commit that referenced this pull request Aug 15, 2023
@kfox1111 @marcofranssen @faisal-memon
Add a FAQ and switch rare issue from README to it (#437)
a52818a 
fixes #433
closes #385

---------

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
Co-authored-by: Marco Franssen <marco.franssen@gmail.com>
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faisal-memon faisal-memon faisal-memon left review comments

@kfox1111 kfox1111 kfox1111 approved these changes

@marcofranssen marcofranssen Awaiting requested review from marcofranssen

@developer-guy developer-guy Awaiting requested review from developer-guy

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

@edwbuck edwbuck Awaiting requested review from edwbuck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cccsss01 @faisal-memon @marcofranssen @kfox1111