New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce go modules #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
amartinezfayo
commented
Oct 4, 2019
- Introduce go modules
- Use log package for logging
- Use log package for logging Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
force-pushed
the
go-modules
branch
from
October 4, 2019 13:43
6a892c1
to
0b032af
Compare
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
MarcosDY
reviewed
Oct 4, 2019
@@ -3,14 +3,13 @@ | |||
build: | |||
go build | |||
|
|||
all: utils vendor build test | |||
all: utils build test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may you add
export GO111MODULE=on```
MarcosDY
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
faisal-memon
added a commit
that referenced
this pull request
Jul 20, 2023
* Adds integration tests for mysql, postgres and go client-server. Signed-off-by: JU4N98 <juanpablocabana2@gmail.com> * Fixes spiffe-helper dockerfile. Signed-off-by: JU4N98 <juanpablocabana2@gmail.com> * Adds integration tests to workflows. Signed-off-by: JU4N98 <juanpablocabana2@gmail.com> * Adds build-matrix job Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Add strategy to integration test (#9) * adds strategy Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * changes bash command Signed-off-by: FedeNQ <fedenahuel07@gmail.com> --------- Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Fix strategy matrix (#11) * Change location of test files Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change location of restore-entry-test Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change location of restore-entry-test Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Adds shell in Run tests Signed-off-by: FedeNQ <fedenahuel07@gmail.com> --------- Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Changes exit code in tests (#12) Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * change on max_attempts Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * change max_attempts on build.sh Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * increase ttl and attemps Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Move IT folder into .github folder (#15) * Move IT folder to .github folder Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Add ./.github/it to working directory Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change target_dir in tests Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change target_dir Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change target_dir Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Add /.github in path Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * change on docker-compose Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * change target_dir in run-postgres-test Signed-off-by: FedeNQ <fedenahuel07@gmail.com> --------- Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * move IT to tests folder Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * change pr_build Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change target_dir on tests Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change release_build.yaml Signed-off-by: FedeNQ <fedenahuel07@gmail.com> * Change ttl & retries Signed-off-by: FedeNQ <fedenahuel07@gmail.com> --------- Signed-off-by: JU4N98 <juanpablocabana2@gmail.com> Signed-off-by: FedeNQ <fedenahuel07@gmail.com> Co-authored-by: JU4N98 <juanpablocabana2@gmail.com> Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.