Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the test coverage of the spire-server run and spire-agent run commands #3199

Closed
amartinezfayo opened this issue Jun 29, 2022 · 2 comments · Fixed by #3505
Closed

Improve the test coverage of the spire-server run and spire-agent run commands #3199

amartinezfayo opened this issue Jun 29, 2022 · 2 comments · Fixed by #3505
Assignees
@guilhermocc
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@amartinezfayo
Copy link
Member

Current tests don't cover the Run function (in the server and in the agent) that runs the server and the agent.
There are things like endpoints preparation (create / not create directories depending on the transport) that are not currently tested and should be tested.
@amartinezfayo amartinezfayo added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Jun 29, 2022
@amartinezfayo amartinezfayo mentioned this issue Jun 29, 2022
Merged
@guilhermocc
Copy link
Contributor

guilhermocc commented Oct 10, 2022 •
edited

Hello, can i be assigned to this issue, please?

@amartinezfayo
Copy link
Member Author

Thank you for taking this, @guilhermocc!

guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 14, 2022
@guilhermocc
Add test for spire-agent run command on linux OS (spiffe#3199)
13ca20a 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 14, 2022
@guilhermocc
Add test for spire-server run command on linux OS (spiffe#3199)
d862161 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 14, 2022
@guilhermocc
Add test cases for Windows OS on run commands (spiffe#3199)
8b36205 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-agent run command on linux OS (spiffe#3199)
f7f4112 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-server run command on linux OS (spiffe#3199)
57c6505 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test cases for Windows OS on run commands (spiffe#3199)
ef06f87 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
@guilhermocc guilhermocc mentioned this issue Oct 17, 2022
Merged
3 tasks
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-agent run command on linux OS (spiffe#3199)
f1078b2 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <Guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-server run command on linux OS (spiffe#3199)
4c2dba8 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <Guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test cases for Windows OS on run commands (spiffe#3199)
f00ff38 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <Guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-agent run command on linux OS (spiffe#3199)
bf6753b 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test for spire-server run command on linux OS (spiffe#3199)
cfe2652 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 17, 2022
@guilhermocc
Add test cases for Windows OS on run commands (spiffe#3199)
721b7c3 
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guilhermocc guilhermocc

Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve run command test coverage guilhermocc/spire
2 participants
@amartinezfayo @guilhermocc