Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support: prevent the creation of directories for UDS endpoints #3192

Merged
merged 4 commits into from Jun 30, 2022
Merged

Windows support: prevent the creation of directories for UDS endpoints #3192

merged 4 commits into from Jun 30, 2022

Conversation

amartinezfayo
Copy link
Member

Prevent the creation of directories for UDS endpoints.

Fixes #3188.

@amartinezfayo
Windows support: prevent the creation of directories for UDS endpoints
01b9780 
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
@amartinezfayo
Windows support: prevent the creation of directories for UDS endpoints
5d7239b 
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
@amartinezfayo
Windows support: prevent the creation of directories for UDS endpoints
02ab6bc 
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
@amartinezfayo amartinezfayo added this to the 1.3.2 milestone Jun 27, 2022
MarcosDY
MarcosDY reviewed Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great my only comment is that if we may spend some time to create an unit tests to validate than folders are not created when using windows

@amartinezfayo
Copy link
Member Author

Unfortunately, our current testing for the spire-server run and spire-agent run commands does not currently cover the actual running of the server and the agent (the Run function is not tested). I think that ideally, this should be tested as part of the testing of the Run function, which seems to be a separate effort. I've created #3199 for that.
@MarcosDY Would you be OK if that is addressed separately?

MarcosDY
MarcosDY approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@amartinezfayo amartinezfayo merged commit 9fc105e into spiffe:main Jun 30, 2022
@amartinezfayo amartinezfayo deleted the windows-prevent-uds-dir-creation branch March 1, 2023 18:01
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
@amartinezfayo @stevend-uber
Windows support: prevent the creation of directories for UDS endpoints (
b513377 
spiffe#3192)

* Windows support: prevent the creation of directories for UDS endpoints

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY MarcosDY approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@azdagron azdagron Awaiting requested review from azdagron azdagron is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

Windows support: directories for UDS endpoints are created
2 participants
@amartinezfayo @MarcosDY