adds attest Unix workloads by user groups #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
kunzimariano
requested review from
ajessup,
amartinezfayo,
APTy,
azdagron,
evan2645 and
mcpherrinm
as code owners
marcosy
reviewed
Aug 3, 2020
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
azdagron
reviewed
Aug 5, 2020
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mariano Kunzi kunzi.mariano@gmail.com
Affected functionality
Implements attest Unix workloads by user groups
Description of change
Adds 2 new selectors to support supplementary groups.
Which issue this PR fixes
fixes #1657
Some extra context
/proc/[pid]/statusThis PR is currently consuming https://github.com/shirou/gopsutil from their master until they release the Groups() listing feature.supplementary_gidandsupplementary_groupare probably bad names. Any alternative is welcome.- Although macOS is not fully supported there are some caveats I would like to mention, for people that develop on it.- Listing the Groups() is currently broken, I created an issue for it Calling the new process.Groups() fails on macOS shirou/gopsutil#913- The 3 first elements on the list should bereal, effective, and saved set gid. What I have been getting in my local dev machine is0, 20, 0, where20is mystaffgid and0should bewheel. I don't have full knowledge of how macOS handles this but I thought worth mentioning, since it could have unexpected consequences.