datastore: use UNION ALL for postgres list entries query #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
This cuts the cost in time, as determined by EXPLAIN ANALYZE, in half. For a database with ~20000 entries and ~50000 selectors the time goes from ~200ms to ~100ms. The difference between UNION and UNION ALL is that the former also does a DISTINCT step on the entries, removing any duplicates. It's possible I'm missing something simple, but I don't think that actually does anything for us since most of the sub-queries also return an unique primary key so they are already unique. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
rturner3
approved these changes
Apr 27, 2023
d-goro
pushed a commit
to d-goro/spire
that referenced
this pull request
May 18, 2023
This cuts the cost in time, as determined by EXPLAIN ANALYZE, in half. For a database with ~20000 entries and ~50000 selectors the time goes from ~200ms to ~100ms. The difference between UNION and UNION ALL is that the former also does a DISTINCT step on the entries, removing any duplicates. It's possible I'm missing something simple, but I don't think that actually does anything for us since most of the sub-queries also return an unique primary key so they are already unique. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net> Signed-off-by: Dmitry Gorochovsky <d.goro@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Listing registration entries.
Description of change
This cuts the cost in time, as determined by EXPLAIN ANALYZE, in half. For a database with ~20000 entries and ~50000 selectors the time goes from ~200ms to ~100ms.
The difference between UNION and UNION ALL is that the former also does a DISTINCT step on the entries, removing any duplicates. It's possible I'm missing something simple, but I don't think that actually does anything for us here since most of the sub-queries also return an unique primary key so they are already unique.
Similar change can probably be done for the MySQL CTE query, but I haven't tested that yet. Can do that if this is considered an acceptable change.