Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the CI build #378

Closed
maia-iyer opened this issue Mar 26, 2024 · 0 comments · Fixed by #382
Closed

Improve the CI build #378

maia-iyer opened this issue Mar 26, 2024 · 0 comments · Fixed by #382
Assignees
@maia-iyer
Labels
github_actions Pull requests that update GitHub Actions code
Milestone
1.6.x

Comments

@maia-iyer
Copy link
Collaborator

  1. Propose to build and publish an image on PR (with a git sha tag) for easier testing. Perhaps if we can create a trigger to make the image as a final test, instead of running on every PR commit.
  2. Propose to parallelize the jobs at least in the image push action
@maia-iyer maia-iyer added the github_actions Pull requests that update GitHub Actions code label Mar 26, 2024
@maia-iyer maia-iyer added this to the 1.6.x milestone Mar 26, 2024
@maia-iyer maia-iyer self-assigned this Mar 26, 2024
@maia-iyer maia-iyer mentioned this issue Mar 27, 2024
Merged
maia-iyer added a commit that referenced this issue Mar 28, 2024
@maia-iyer
Split Master Build into two jobs (#378) (#382)
f575f46 
* Modified workflow

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* fix workflow syntax

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* moving action yaml

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nit

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nit

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* add shell

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* shell for each action comman

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nit fixes

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* fix ubi build

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nit

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* add tagging logic

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nit fix

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* add tag logic to ubi build

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* remove qemu

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* attempt to fix build with alpine build

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

---------

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maia-iyer maia-iyer

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
1.6.x
Development

Successfully merging a pull request may close this issue.

Split Master Build into two jobs (#378) spiffe/tornjak
1 participant
@maia-iyer