Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename images to include frontend and backend suffix #178

Merged
merged 6 commits into from
May 5, 2023
Merged

Rename images to include frontend and backend suffix #178

merged 6 commits into from
May 5, 2023

Conversation

mrsabath
Copy link
Collaborator

@mrsabath mrsabath commented May 1, 2023

This is addressing issue #169

@mrsabath
Change the version.txt to v1.2.0
75729a6 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath
Rename images to include backend and frontend suffix
6e4c264 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath changed the base branch from main to v1.2.0 May 1, 2023 21:17
@mrsabath mrsabath added this to the 1.2.x milestone May 1, 2023
@mrsabath
Add release version to master-build workflow
0b57e75 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath marked this pull request as ready for review May 2, 2023 00:09
@mrsabath mrsabath requested a review from lumjjb as a code owner May 2, 2023 00:09
@mrsabath
Test the image build
c87082d 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
maia-iyer
maia-iyer approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/master-build.yaml Outdated Show resolved Hide resolved
@maia-iyer maia-iyer linked an issue May 2, 2023 that may be closed by this pull request
Convert image names to spell out the component name #169
Closed
@mrsabath mrsabath merged commit 1d4de74 into v1.2.0 May 5, 2023
@mrsabath mrsabath deleted the image-name branch May 5, 2023 11:56
@maia-iyer maia-iyer mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maia-iyer maia-iyer maia-iyer approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.

Convert image names to spell out the component name
2 participants
@mrsabath @maia-iyer