Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically change frontend env variables and reduce image size #220

Merged
merged 3 commits into from
May 18, 2023
Merged

Dynamically change frontend env variables and reduce image size #220

merged 3 commits into from
May 18, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented May 16, 2023

@mamy-CS
dynamically change frontend env variables
5cee8b2 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS added the frontend Tornjak UI (Frontend) label May 16, 2023
@mamy-CS mamy-CS added this to the 1.2.x milestone May 16, 2023
@mamy-CS mamy-CS self-assigned this May 16, 2023
mrsabath
mrsabath approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this change to production! LGTM

@mrsabath mrsabath merged commit fcad514 into spiffe:v1.2 May 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsabath mrsabath mrsabath approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

Assignees

@mamy-CS mamy-CS

Labels
frontend Tornjak UI (Frontend)
Projects
None yet
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mamy-CS @mrsabath