Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuerURL info in OIDC Discovery error handling (#394) #398

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

nesangcode
Copy link
Contributor

@nesangcode nesangcode commented Apr 8, 2024

  • Adding issuerURL info in OIDC Discovery error handling

Before:

2024/04/08 12:19:16 Cannot Configure: Cannot configure auth plugin: Couldn't configure Auth: Could not set up OIDC Discovery client: error

After:

2024/04/08 12:19:16 Cannot Configure: Cannot configure auth plugin: Couldn't configure Auth: Could not set up OIDC Discovery client with issuer = '<insert IssuerURL>': error

closes #394

Signed-off-by: k124k3n <k124k3n@gmail.com>
@maia-iyer maia-iyer added the backend Tornjak API (Backend) label Apr 8, 2024
@maia-iyer maia-iyer added this to the 1.6.x milestone Apr 8, 2024
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully tested and LGTM! Thank you for your contribution!

@maia-iyer maia-iyer merged commit abc46f2 into spiffe:v1.6 Apr 9, 2024
2 checks passed
@nesangcode
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper backend Auth config error handling
2 participants