Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertebral level is off by one level when using -initc2 #1570

Closed
jcohenadad opened this issue Jan 15, 2018 · 0 comments
Closed

Vertebral level is off by one level when using -initc2 #1570

jcohenadad opened this issue Jan 15, 2018 · 0 comments
Assignees
@jcohenadad
Labels
bug category: fixes an error in the code priority:HIGH sct_label_vertebrae context:
Milestone
3.1.1

Comments

@jcohenadad
Copy link
Member

jcohenadad commented Jan 15, 2018 •
edited

Description

Vertebral level is off by one level when using -initc2. The function works well otherwise. This bug was introduced in 21f3628.

Steps to Reproduce

cd sct_example_data/t2
sct_label_vertebrae -i t2.nii.gz -s t2_seg.nii.gz -c t2 -v 2 -initc2

State of spinalcordtoolbox

Spinal Cord Toolbox (master/36f429e3adb5855b98ce688514c844cf313a15bd)

Additional Information

screen shot 2018-01-15 at 14 16 02
@jcohenadad jcohenadad self-assigned this Jan 15, 2018
@jcohenadad jcohenadad added bug category: fixes an error in the code priority:HIGH sct_label_vertebrae context: fix:major labels Jan 15, 2018
@jcohenadad jcohenadad added this to the 3.1.1 milestone Jan 15, 2018
jcohenadad added a commit that referenced this issue Jan 15, 2018
@jcohenadad
BUG: label_vertebrae: Updated label disc value (fixes #1570)
f43dc1c
@jcohenadad jcohenadad mentioned this issue Jan 15, 2018
Merged
jcohenadad added a commit that referenced this issue Jan 16, 2018
@jcohenadad
Bug fix and various improvements (#1571)
e1bc19c 
* BUG: label_vertebrae: Updated label disc value (fixes #1570)

* REF: fixed typo

* OPT: label_vertebrae: Added instructions above image for sagittal dialog (fixes #1563)
peristeri pushed a commit that referenced this issue Jan 17, 2018
@jcohenadad @peristeri
Bug fix and various improvements (#1571)
4b14a2d 
* BUG: label_vertebrae: Updated label disc value (fixes #1570)

* REF: fixed typo

* OPT: label_vertebrae: Added instructions above image for sagittal dialog (fixes #1563)
jcohenadad pushed a commit that referenced this issue Mar 27, 2018
@peristeri @jcohenadad
Added navigation features to the sagittal and centerline GUI (#1545)
edd2a08 
* Added navigation features to the sagittal and centerline GUI

The user can now nagivate using the arrow keys. Also, update the canvas dragging
the mouse along the canvas.

Implements #1501

* Bug fix and various improvements (#1571)

* BUG: label_vertebrae: Updated label disc value (fixes #1570)

* REF: fixed typo

* OPT: label_vertebrae: Added instructions above image for sagittal dialog (fixes #1563)

* Implemented the changes suggested in pull request comments.

* Implemented the suggestions in the pull request

* Fixed few typos

* removed useless lines (because those variables are assigned later in the code)

* Fixed: in centerline-custom mode, reset position should start at the top

* clarified code

* increased number of max points for centerline (previously 11)

* added interval in base config and set absolute value within sct_propseg because it was previously too large for mode init-mask

* cleaned up debug code

* fixed typo

* adjust aspect ratio based on pixel dimension

* changed parameter name for interval_in_mm to avoid confusion

* added todo

* updated misleading variable name

* Fixed identification of axial slice when input is not RPI (propseg was wrongly calling nz param, which is orientation dependent)

* added checks if initial slice is out of range or is a fraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcohenadad jcohenadad

Labels
bug category: fixes an error in the code priority:HIGH sct_label_vertebrae context:
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
1 participant
@jcohenadad