Bug fix and various improvements #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
added
bug
jcohenadad
changed the title
jcohenadad
requested review from
benjamindeleener,
stephaniealley and
peristeri
stephaniealley
approved these changes
Jan 15, 2018
peristeri
approved these changes
Jan 16, 2018
peristeri
pushed a commit
that referenced
this pull request
Jan 17, 2018
jcohenadad
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Added navigation features to the sagittal and centerline GUI The user can now nagivate using the arrow keys. Also, update the canvas dragging the mouse along the canvas. Implements #1501 * Bug fix and various improvements (#1571) * BUG: label_vertebrae: Updated label disc value (fixes #1570) * REF: fixed typo * OPT: label_vertebrae: Added instructions above image for sagittal dialog (fixes #1563) * Implemented the changes suggested in pull request comments. * Implemented the suggestions in the pull request * Fixed few typos * removed useless lines (because those variables are assigned later in the code) * Fixed: in centerline-custom mode, reset position should start at the top * clarified code * increased number of max points for centerline (previously 11) * added interval in base config and set absolute value within sct_propseg because it was previously too large for mode init-mask * cleaned up debug code * fixed typo * adjust aspect ratio based on pixel dimension * changed parameter name for interval_in_mm to avoid confusion * added todo * updated misleading variable name * Fixed identification of axial slice when input is not RPI (propseg was wrongly calling nz param, which is orientation dependent) * added checks if initial slice is out of range or is a fraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
-initc2.initc2flag