Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored WM atlas creation pipeline and improved documentation #1492

Merged
merged 6 commits into from
Oct 14, 2017

Conversation

jcohenadad
Copy link
Member

The main modification is that the file create_atlas.m is now a function (previously a script) that calls a parameter.m file, which is set for each project

@jcohenadad jcohenadad added this to the Release v3.0.9 milestone Oct 13, 2017
@jcohenadad jcohenadad added enhancement category: improves performance/results of an existing feature documentation category: readthedocs, sourceforge, or SCT courses labels Oct 13, 2017
…olbox into jca_refactorAtlas

* 'jca_refactorAtlas' of github.com:neuropoly/spinalcordtoolbox:
  Added key bindings to the undo, save and help actions. (#1480)
Copy link
Contributor

@stephaniealley stephaniealley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and content are much more clear now.

@jcohenadad jcohenadad merged commit cef1a8d into master Oct 14, 2017
jcohenadad added a commit that referenced this pull request Oct 27, 2017
* master: (43 commits)
  BUG: put back default value for labels (made batch_processing crash)
  BUG: replaced run(mkdir) with python’s makedirs
  raise in sct.run in bad order. Also added specific sct errors (#1503)
  Major refactoring of testing framework (#1453)
  More improvements to the viewer (#1496)
  DEV: add a line in the output excel that compute the percentage of a given tract occupied by lesionS: vol_lesionS_in_PAM50_04 / vol_PAM50_04_tot
  BUG: fix errors in create_atlas.m (#1499)
  Used the absolute path to create the temporary label file in propseg (#1487)
  Option to install SCT in development mode (#1491)
  Refactored WM atlas creation pipeline and improved documentation  (#1492)
  Updated bibliographic URL on ReadMe (#1489)
  Fix a regression bug.
  Added key bindings to the undo, save and help actions. (#1480)
  OPT: propseg: fixed issue 1484 (#1485)
  Fixed global dependency in sct_process_segmentation call (#1481)
  Introduced the zoom functionality to the anatomical canvas (#1477)
  Poq issue 1409 log (#1411)
  The minimal QT dialog  (#1379)
  Update README.md
  download_data: forgot to add pmj_models in the -d flag
  ...
jcohenadad added a commit that referenced this pull request Oct 27, 2017
* jca-release: (44 commits)
  updated CHANGES for 3.1
  BUG: put back default value for labels (made batch_processing crash)
  BUG: replaced run(mkdir) with python’s makedirs
  raise in sct.run in bad order. Also added specific sct errors (#1503)
  Major refactoring of testing framework (#1453)
  More improvements to the viewer (#1496)
  DEV: add a line in the output excel that compute the percentage of a given tract occupied by lesionS: vol_lesionS_in_PAM50_04 / vol_PAM50_04_tot
  BUG: fix errors in create_atlas.m (#1499)
  Used the absolute path to create the temporary label file in propseg (#1487)
  Option to install SCT in development mode (#1491)
  Refactored WM atlas creation pipeline and improved documentation  (#1492)
  Updated bibliographic URL on ReadMe (#1489)
  Fix a regression bug.
  Added key bindings to the undo, save and help actions. (#1480)
  OPT: propseg: fixed issue 1484 (#1485)
  Fixed global dependency in sct_process_segmentation call (#1481)
  Introduced the zoom functionality to the anatomical canvas (#1477)
  Poq issue 1409 log (#1411)
  The minimal QT dialog  (#1379)
  Update README.md
  ...

# Conflicts:
#	dev/straightening/sct_straighten_spinalcord_LargeFOVOutput.py
@peristeri peristeri deleted the jca_refactorAtlas branch March 26, 2018 18:25
jcohenadad added a commit that referenced this pull request Dec 18, 2019
* jca-release: (44 commits)
  updated CHANGES for 3.1
  BUG: put back default value for labels (made batch_processing crash)
  BUG: replaced run(mkdir) with python’s makedirs
  raise in sct.run in bad order. Also added specific sct errors (#1503)
  Major refactoring of testing framework (#1453)
  More improvements to the viewer (#1496)
  DEV: add a line in the output excel that compute the percentage of a given tract occupied by lesionS: vol_lesionS_in_PAM50_04 / vol_PAM50_04_tot
  BUG: fix errors in create_atlas.m (#1499)
  Used the absolute path to create the temporary label file in propseg (#1487)
  Option to install SCT in development mode (#1491)
  Refactored WM atlas creation pipeline and improved documentation  (#1492)
  Updated bibliographic URL on ReadMe (#1489)
  Fix a regression bug.
  Added key bindings to the undo, save and help actions. (#1480)
  OPT: propseg: fixed issue 1484 (#1485)
  Fixed global dependency in sct_process_segmentation call (#1481)
  Introduced the zoom functionality to the anatomical canvas (#1477)
  Poq issue 1409 log (#1411)
  The minimal QT dialog  (#1379)
  Update README.md
  ...

# Conflicts:
#	dev/straightening/sct_straighten_spinalcord_LargeFOVOutput.py


Former-commit-id: 45518c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation category: readthedocs, sourceforge, or SCT courses enhancement category: improves performance/results of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants