New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all 45 sct_testing
tests with Pytest equivalents
#3373
Conversation
d06f961
to
e6099d8
Compare
d964d7a
to
ee44471
Compare
ee44471
to
8e4231b
Compare
09fc5cc
to
41530d6
Compare
* Fix docstring * Test all dim values
c0eb8dd
to
00a61ca
Compare
Thank you so, so much for taking the time to provide such detailed feedback, @kousu. I think I've answered all of your feedback. If it's not too much trouble, could you go through your comments and mark them as "resolved" if you're satisfied by the changes? 🙂 If everything looks good, I can rebase the bugfixes into the main commits so that the "Commit" view is useful again. (Or, maybe I can just merge at this point -- there's diminishing returns to multiple rounds of reviews here, especially because we're going to continue to update these tests with more thorough checks.) |
00a61ca
to
ddca03f
Compare
Checklist
GitHub
PR contents
Description
This PR replaces
sct_testing
withpytest
. The motivation for this is summarized here: #3093 (comment)45 of the commits in this PR do the following:
sct_testing
test.pytest
test to replace these older tests.Then, there are 4 additional commits:
pytest -m sct_testing
behaves identically tosct_testing
.sct_register_multimodal.py
discovered by the new tests.spinalcordtoolbox/scripts/sct_testing.py
itself.How to review this PR
To review this PR, please compare each old
sct_testing
test to the newpytest
test to make sure they match up. (For example, comparetesting/test_sct_analyze_lesion.py
withunit_testing/cli/test_cli_sct_analyze_lesion.py
.)To make this easier, use "Commit" view, because each commit will contain a pair of test files.
Linked issues
Fixes #3093.
Fixes #2133.