New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for sct_dmri_display_bvecs
, then add -v
argument to make the test pass
#3387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@joshuacwnewton Thanks for incredibly fast workaround. I have just tried your branch and now it works! Thanks! |
Hrm... the Catalina build has stalled for the past 2.75hr... restarting now. 😅 |
OK, it's still stalling even after a restart. I ran into a similar problem in #3373 with aa23154:
Since this is the second time this has happened, I'd like to try and find an explanation... |
Ah, my hunch is that it has to do with tests that invoke EDIT: Confirmed by 3b5aefe! |
This should be addressed by #3388.
Checklist
GitHub
PR contents
Description
#3091 added loglevel setting steps to all SCT scripts. However,
sct_dmri_display_bvecs
never had a verbose argument.This was never caught because there is no test for
sct_dmri_display_bvecs
. So, this adds an (admittedly very basic) test for the script. (A more thorough test would require some refactoring ofsct_dmri_display_bvecs
.)This test fails on master, but passes on this branch after
-v
is added.Linked issues
Fixes #3386.