Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sct_compute_compression and sct_process_segmentation references #4425

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

valosekj
Copy link
Member

@valosekj valosekj commented Apr 9, 2024

This is a minor PR updating the sct_compute_compression and sct_process_segmentation references.

Namely, the PR:

Resolves: #4343

Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DOI links themselves all work for me! I just had some minor feedback on the formatting, since we now have a list of references.

I'm pre-approving since this is a very simple change. :)

@valosekj
Copy link
Member Author

valosekj commented Apr 9, 2024

Thank you! I agree with your changes!

@mguaypaq
Copy link
Member

mguaypaq commented Apr 9, 2024

The diff link checker worked! Although I'm not sure why it skipped 3 of the 5 URLs, they don't look like they match our excluded domains.

@joshuacwnewton
Copy link
Member

The diff link checker worked! Although I'm not sure why it skipped 3 of the 5 URLs, they don't look like they match our excluded domains.

Ah!

@mguaypaq mguaypaq merged commit d59b426 into master Apr 10, 2024
20 checks passed
@mguaypaq mguaypaq deleted the jv/4343_update_refs branch April 10, 2024 00:42
@joshuacwnewton joshuacwnewton added this to the 6.3 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sct_compute_compression and sct_process_segmentation refs
3 participants